Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(genesis): rm EIP150Hash #1039

Merged
merged 2 commits into from
Jul 11, 2024
Merged

feat(genesis): rm EIP150Hash #1039

merged 2 commits into from
Jul 11, 2024

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Jul 11, 2024

Motivation

As EIP150Hash was removed in geth, so I think we can also remove them, ref https://github.com/ethereum/go-ethereum/blob/v1.14.0/params/config.go#L326

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

jsvisa added 2 commits July 11, 2024 21:27
Signed-off-by: jsvisa <delweng@gmail.com>
Signed-off-by: jsvisa <delweng@gmail.com>
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed over a year ago in ethereum/go-ethereum#27087

@mattsse mattsse merged commit 408ae75 into alloy-rs:main Jul 11, 2024
22 checks passed
@jsvisa jsvisa deleted the rm-eip150-hash branch July 11, 2024 14:17
ben186 pushed a commit to ben186/alloy that referenced this pull request Jul 27, 2024
* feat(genesis): rm eip150_hash

Signed-off-by: jsvisa <delweng@gmail.com>

* fix testcase

Signed-off-by: jsvisa <delweng@gmail.com>

---------

Signed-off-by: jsvisa <delweng@gmail.com>
j75689 pushed a commit to bnb-chain/alloy that referenced this pull request Aug 1, 2024
* feat(genesis): rm eip150_hash

Signed-off-by: jsvisa <delweng@gmail.com>

* fix testcase

Signed-off-by: jsvisa <delweng@gmail.com>

---------

Signed-off-by: jsvisa <delweng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants