Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using some crates with SP1 #1112

Open
manav2401 opened this issue Jul 31, 2024 · 2 comments
Open

Support for using some crates with SP1 #1112

manav2401 opened this issue Jul 31, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@manav2401
Copy link

Component

other

Describe the feature you would like

I want to use alloy-primitives and alloy-rlp as a dependency in SP1 but it doesn't compile. It'll be great if this command worked for these 2 crates.

Thanks!

Additional context

No response

@manav2401 manav2401 added the enhancement New feature or request label Jul 31, 2024
@mattsse mattsse self-assigned this Jul 31, 2024
@DaniPopes
Copy link
Member

DaniPopes commented Jul 31, 2024

Can you please elaborate on "it doesn't compile"? All of the crates in that script depend on either alloy-primitives, alloy-rlp, or both, so by default these also compile using that command.

@manav2401
Copy link
Author

All of the crates in that script depend on either alloy-primitives, alloy-rlp, or both, so by default these also compile using that command.

Ahh didn't know that, thanks!

Can you please elaborate on "it doesn't compile"?

Sure. Basically I added reth-primitives, alloy-primitives and alloy-rlp as a dependency in my SP1 project. While the root rust program compiles well, SP1's zkVM can't really compile the programme for generating proofs. I had a discussion with their team and they mentioned that they maintain a custom fork for such compatibility changes. I thought it will be great to have those custom changes (which I am not fully aware of) in the main repo itself. They mentioned that they'll create these PRs and they'll also update the CI such that any changes which affects their lifecycle gets caught.

TL;DR: This might be something which their team will take a look into. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants