Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom file names #772

Closed
kottameister opened this issue Jun 14, 2021 · 7 comments · Fixed by #794
Closed

Add support for custom file names #772

kottameister opened this issue Jun 14, 2021 · 7 comments · Fixed by #794

Comments

@kottameister
Copy link

kottameister commented Jun 14, 2021

Hi,

I noticed that Export to CSV doesn’t use a descriptive name in the file name any more, but simply turnilo-export.csv. It might be related to #747. Would it be possible to support encoding without hardcoding the file name?

Thanks

@adrianmroz
Copy link
Collaborator

adrianmroz commented Jun 14, 2021

Hi,

Yes we removed dynamic file names for exported csv/tsv. Code responsible for this was convoluted and unreliable. Names weren’t good either. For sure we’re not going to bring it back.

But, we’re open to suggestions how file names should look. Feel free to submit some reasonable schemes and we could discuss if they’re feasible to implement.

Cheers!

@kottameister
Copy link
Author

kottameister commented Jun 15, 2021

Hi,

Thanks for the response. Could there be a configurable template for the file name so that user doesnt have to specify it every time? For our use case, we'd like something like <report_id>_<starttime>_<endtime>

@adrianmroz-allegro
Copy link
Contributor

adrianmroz-allegro commented Jun 16, 2021

I don't think we want to add filename template to config.

report_id_starttime_endtime

Sounds doable, can I get some feedback from others?

@aagoath
Copy link

aagoath commented Jun 30, 2021

@adrianmroz the generated file name would be good. is there a unique report_id generated when report is built, which can be used here? I think <starttime> & <endtime> will be valuable if they are in form of yyy-mm-dd-hh-mm-ss.

@adrianmroz
Copy link
Collaborator

@adrianmroz is there a unique report_id generated when report is built, which can be used here?

Nope. I was thinking that would be data cube id.

@adrianmroz-allegro
Copy link
Contributor

@aagoath @kottameister What do you think about this:
image

@aagoath
Copy link

aagoath commented Sep 3, 2021

@adrianmroz this looks exactly what we were looking for. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants