-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust granularity automatically only if necessary #227
Comments
Granularity is decided there: turnilo/src/common/models/splits/splits.ts Lines 123 to 153 in 08d1a16
This method is called whenever splits change or filters change. We should limit that. |
Hmm, looks like we have a bug there - we search clause by type, we should search by split reference and type. turnilo/src/common/models/splits/splits.ts Line 136 in 08d1a16
|
Observations:
|
Probably linked with #598 |
Right now when changing anything in time filter, granularity of time split is adjusted by RulesEvaluator and often it changes granularity unnecessarily.
Goal should be to:
At first, we need to check what's possible with current implementation of RulesEvaluator.
The text was updated successfully, but these errors were encountered: