Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持context.Context #100

Closed
swagerebus opened this issue Jun 5, 2018 · 4 comments
Closed

支持context.Context #100

swagerebus opened this issue Jun 5, 2018 · 4 comments

Comments

@swagerebus
Copy link

现在主流都是一个参数传context.Context, 用于取消请求或者设置超时

是否考虑支持一下?
@rmrf
Copy link

rmrf commented Jan 8, 2019

同问，没有 context， 跟其他golang 项目集成是个大问题

@hangzws
Copy link
Collaborator

hangzws commented Jan 10, 2019

context要go 1.7版本才支持的吧，sdk要考虑到支持各种版本，目前不支持。

@rmrf
Copy link

rmrf commented Jan 10, 2019

context要go 1.7版本才支持的吧，sdk要考虑到支持各种版本，目前不支持。

golang 的 context 是很重要的一个升级，尤其对于 http 相关调用，对OSS来说也很重要，尤其是主流的开源项目基本都升级了。 如果考虑兼容性的话， 个人认为这个“兼容”其实更加重要一些。

@hangzws
Copy link
Collaborator

hangzws commented Jan 10, 2019

@rmrf 欢迎提交pr

@hangzws hangzws closed this as completed Jan 10, 2019
@YuZhangForWeb YuZhangForWeb mentioned this issue Feb 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmrf @hangzws @swagerebus