Dev jingdan #50
Merged
Dev jingdan #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jingdan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
added 3 commits
August 22, 2017 10:04
1019272778
reviewed
Aug 22, 2017
added 4 commits
August 22, 2017 11:17
|
added 13 commits
August 23, 2017 14:14
|
添加测试覆盖率步骤 需要先在OSSTestConfig中修改配置变量 执行生成测试case覆盖率 指令 |
baiyubin
reviewed
Sep 4, 2017
README-CN.md
Outdated
| OSSCredentialProvider credentialProvider = new OSSStsTokenCredentialProvider("<StsToken.AccessKeyId>", "<StsToken.SecretKeyId>", "<StsToken.SecurityToken>"); | ||
|
|
||
| OSS oss = new OSSClient(getApplicationContext(), endpoint, credentialProvider); | ||
| OSS oss = new OSSClient(getApplicationContext(), endpoint, credentialProvider,conf); |
There was a problem hiding this comment.
credentialProvider,conf->credentialProvider, confconf前添加一个空格。其它地方不再提醒。公司Java代码规范请参看集团开发规。
baiyubin
reviewed
Sep 4, 2017
| public static void init(Context context, ClientConfiguration cfg) { | ||
| log(Log.INFO,"init ..."); | ||
| if (null == sContext || null == instance || null == sLogFile || !sLogFile.exists()) { | ||
| if(cfg!=null) { |
There was a problem hiding this comment.
- cfg!=null -> cfg != null，请正确使用空格，空行，具体要求请参看https://www.atatech.org/articles/50331，其它地方不在提示。
baiyubin
reviewed
Sep 4, 2017
| log(Log.INFO, "LogFilePath is: " + sLogFile.getPath()); | ||
| // 获取当前日志文件大小 | ||
| long logFileSize = getFileSize(sLogFile); | ||
| log(Log.DEBUG, "Log max size is: " + Formatter.formatFileSize(context, LOG_MAX_SIZE)); |
baiyubin
reviewed
Sep 4, 2017
| if (file!=null && file.exists()) { | ||
| try { | ||
| FileInputStream fis = new FileInputStream(file); | ||
| size = fis.available(); |
There was a problem hiding this comment.
- FileInputStream.available返回的是文件估算长度，另外返回的是int大于2G的问题会出问题。请确认。
There was a problem hiding this comment.
这个只是内部使用读取日志文件大小， 日志文件大小基本不会超过5M
baiyubin
reviewed
Sep 4, 2017
| // 若目录不存在则创建目录 | ||
| if(canStorage) { | ||
| if (!file.exists()) { | ||
| file.mkdir(); |
baiyubin
reviewed
Sep 4, 2017
| * | ||
| * @return 当前函数的信息 | ||
| */ | ||
| private String getFunctionInfo(StackTraceElement[] sts) { |
There was a problem hiding this comment.
StackTraceElement[] sts -> StackTraceElement[] ste
baiyubin
reviewed
Sep 4, 2017
| //写入普通log | ||
| pw.println(getInstance().getFunctionInfo(null) + " - " + mStr.toString()); | ||
| } | ||
| pw.println("-----------------------------------------------------------------------"); |
There was a problem hiding this comment.
pw.println("-----------------------------------------------------------------------"); 调试信息吗?如果是去除.
There was a problem hiding this comment.
是日志文件 里边 不同日志 分割线
baiyubin
reviewed
Sep 4, 2017
| //输出流操作 输出日志信息至本地存储空间内 | ||
| PrintWriter pw = new PrintWriter(new BufferedWriter(new FileWriter(sLogFile,true))); | ||
| if(pw!=null) { | ||
| log(Log.DEBUG,"文件存在:"+sLogFile.exists()); |
There was a problem hiding this comment.
log(Log.DEBUG,"文件存在:"+sLogFile.exists())日志里面打印 英文,不要有中文,放在乱码出现.
baiyubin
reviewed
Sep 4, 2017
|
|
||
| public class OSSLogToFileUtils { | ||
|
|
||
| private static ExecutorService logService = Executors.newSingleThreadExecutor(); |
There was a problem hiding this comment.
newSingleThreadExecutor默认应该不限任务队列长度的，会造成内存使用过大，请限制队列长度，合理处理入队失败的任务。
There was a problem hiding this comment.
fixed 替换一个有限队列进行最大控制
baiyubin
reviewed
Sep 4, 2017
| private PrintWriter setBaseInfo(PrintWriter pw){ | ||
| //导出手机信息和异常信息 | ||
| pw.println("android版本号：" + Build.VERSION.RELEASE); | ||
| pw.println("手机型号：" + Build.MODEL); |
There was a problem hiding this comment.
android版本号：,手机型号：,运营商：请使用英文。非注释代码不要出现中文。
baiyubin
reviewed
Sep 4, 2017
| } | ||
| } | ||
|
|
||
| private static void log(int level,String msg){ |
baiyubin
reviewed
Sep 4, 2017
| } | ||
| catch(UnsupportedEncodingException ex){ | ||
| throw new RuntimeException("Unsupported algorithm: " + DEFAULT_ENCODING); | ||
| //not enter |
There was a problem hiding this comment.
这个编码 是写死的utf-8 api默认支持这个格式 ，如果传入的格式参数是用户自己调用的 那么这个异常会发生， 否则 这个异常不会发生
baiyubin
reviewed
Sep 4, 2017
| } | ||
| catch(NoSuchAlgorithmException ex){ | ||
| throw new RuntimeException("Unsupported algorithm: " + ALGORITHM); | ||
| //not enter |
baiyubin
reviewed
Sep 4, 2017
| } catch (NoSuchAlgorithmException e) { | ||
| throw new RuntimeException("MD5 algorithm not found."); | ||
| //not enter |
baiyubin
reviewed
Sep 4, 2017
| @@ -70,9 +76,21 @@ public static void logW(String msg) { | |||
| * @param msg | |||
| */ | |||
| public static void logD(String msg) { | |||
| logD(msg,true); | |||
There was a problem hiding this comment.
- logD建议叫logDebug，logE叫logError，logI叫logInfo，这样比较易读，代码阅读者不需要思考猜测。
added 5 commits
September 5, 2017 16:44
…-sdk into dev_jingdan Conflicts: oss-android-sdk/src/main/java/com/alibaba/sdk/android/common/utils/HttpUtil.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.