Skip to content

[OpenAPI] Add endpoint for create event details #212 #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

DOZAKA
Copy link
Contributor

@DOZAKA DOZAKA commented Aug 23, 2024

Related to #212

This PR is:

To add endpoint for create event details

[작업 내역]

  • [AzureOpenAIIProxy.ApiApp] Endpoints.AdminEndpointUrls 내 AdminEvent url(/admin/events) 추가
  • [AzureOpenAIIProxy.ApiApp] Endpoints.AdminEventEndpoints 내 CreateAdminEvent 메소드 작성
  • [AzureOpenAIIProxy.ApiApp] 관리자 이벤트 상세 조회 API 이슈에서 생성한 AdminEventDetails 모델을 기반으로 관리자 이벤트 등록용 모델(Models.AdminEvent) 생성
  • [AzureOpenAIIProxy.ApiApp] Program.cs 내 app.CreateAdminEvent() 등록
  • [OpenAPI] Add endpoint for view event details [OpenAPI] Add endpoint for view event details #207 관련 머지([OpenAPI] Add endpoint for view event details #207 #231) 내 기능과 불일치한 메소드 명 변경(AddAdminEvents -> GetAdminEventDetails)

OpenAPI: swagger.json

swagger_image

@DOZAKA DOZAKA changed the title Feature/212 add endpoint for create event details [OpenAPI] Add endpoint for create event details #212 Aug 23, 2024
@justinyoo justinyoo linked an issue Aug 24, 2024 that may be closed by this pull request
Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 남겨뒀습니다.

@DOZAKA
Copy link
Contributor Author

DOZAKA commented Aug 24, 2024

[작업 내역]

  • AdminEvent 모델 제거 (AdminEventDetails 모델 재사용)
  • EventId 타입 변경 (string -> GUID)

OpenAPI: swagger.json

스크린샷 2024-08-24 오전 11 45 31

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쟈... 이제 얼추 다 됐구요, 테스트 코드를 작성해 주세요!

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

두어가지만 수정하면 될 듯 합니다!

Copy link
Contributor

@justinyoo justinyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다!

@justinyoo justinyoo merged commit 81c8c6e into aliencube:main Aug 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenAPI] Add endpoint for create event details
2 participants