[OpenAPI] Add endpoint for view event details #207 #231

juhangil · 2024-08-18T09:35:14Z

#207

Get: Event details by admin endpoint class 추가
Url constant 추가
Response dto 추가

러프하게 작업을 진행해봤습니다
혹시 방향성이 맞을까요?

justinyoo

@juhangil 첫 시작이 아주 좋습니다! 코멘트 남겨뒀구요, 이와 관련해서 테스트 코드도 좀 만들어 볼까요?

만약 테스트 코드 짜는 게 감이 안오면 말씀해 주세요.

src/AzureOpenAIProxy.ApiApp/Endpoints/AdminEventDetailsEndpoint.cs

src/AzureOpenAIProxy.ApiApp/Endpoints/EndpointUrls.cs

src/AzureOpenAIProxy.ApiApp/Models/AdminEventDetails.cs

src/AzureOpenAIProxy.ApiApp/Endpoints/AdminEventDetailsEndpoint.cs

- remove fake implementation in admin event details endpoint - Replace event details url file, EndpointUrls.cs to AdminEndpointUrls.cs - Rename AdminEventDetailsEndpoint.cs to AdminEventEndpoints.cs - Change url route parameter eventID to eventId

github-actions · 2024-08-18T14:44:29Z

Test Results

✔️ Tests 35 / 35 - passed in 19.2s
🔍 click here for more details

✏️ updated for commit 88974a8

github-actions · 2024-08-18T14:44:29Z

Test Results

Tests

📋 Total	✔️ Passed	❌ Failed	⚠️ Skipped
35	35	0	0

src/AzureOpenAIProxy.ApiApp/Endpoints/AdminEventEndpoints.cs

src/AzureOpenAIProxy.ApiApp/Program.cs

- AddAdminEventDetails to AddAdminEvents - Replace region to comment

…-details Add admin event api unit test for path

…thub.com/juhangil/azure-openai-sdk-proxy into feature/207-endpoint-admin-event-details

github-actions · 2024-08-19T07:20:08Z

Test Results

✔️ Tests 35 / 35 - passed in 16.2s
🔍 click here for more details

✏️ updated for commit ea63552

github-actions · 2024-08-19T07:20:09Z

Test Results

Tests

📋 Total	✔️ Passed	❌ Failed	⚠️ Skipped
35	35	0	0

github-actions · 2024-08-19T07:21:08Z

Test Results

✔️ Tests 35 / 35 - passed in 18.5s
🔍 click here for more details

✏️ updated for commit 2e09556

github-actions · 2024-08-19T07:21:08Z

Test Results

Tests

📋 Total	✔️ Passed	❌ Failed	⚠️ Skipped
35	35	0	0

github-actions · 2024-08-19T07:51:47Z

Test Results

✔️ Tests 35 / 35 - passed in 22.9s
🔍 click here for more details

✏️ updated for commit b4dc2a0

github-actions · 2024-08-19T07:51:48Z

Test Results

Tests

📋 Total	✔️ Passed	❌ Failed	⚠️ Skipped
35	35	0	0

test/AzureOpenAIProxy.AppHost.Tests/Fixture/AspireHostFixture.cs

justinyoo · 2024-08-19T08:04:08Z

좋은데요? 응답 페이로드만 고민해 보면 될 듯 합니다.

juhangil · 2024-08-19T08:08:11Z

좋은데요? 응답 페이로드만 고민해 보면 될 듯 합니다.

네 모델이랑 테스트 적용해서 완료되면 추가로 커밋하겠습니다

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventEventDetailsOpenApiTests.cs

github-actions · 2024-08-19T11:52:32Z

Test Results

✔️ Tests 35 / 35 - passed in 17s
🔍 click here for more details

✏️ updated for commit fc6ca77

github-actions · 2024-08-19T11:52:33Z

Test Results

Tests

📋 Total	✔️ Passed	❌ Failed	⚠️ Skipped
35	35	0	0

juhangil · 2024-08-19T11:52:45Z

@justinyoo 요청하신 변경사항이랑 페이로드 정의 후 테스트 적용하였습니다

github-actions · 2024-08-19T12:00:37Z

Test Results

✔️ Tests 35 / 35 - passed in 17.8s
🔍 click here for more details

✏️ updated for commit a67de9d

github-actions · 2024-08-19T12:00:37Z

Test Results

Tests

📋 Total	✔️ Passed	❌ Failed	⚠️ Skipped
35	35	0	0

src/AzureOpenAIProxy.ApiApp/Models/AdminEventDetails.cs

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventDetailsOpenApiTest.cs

justinyoo

마지막 리뷰가 될 것 같은데, 코드 청소용입니다.

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventDetailsOpenApiTests.cs

src/AzureOpenAIProxy.ApiApp/Models/AdminEventDetails.cs

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventDetailsOpenApiTests.cs

justinyoo

수고하셨습니다!

Add Get event details endpoint by admin

68f8357

juhangil changed the title ~~Add Get event details endpoint by admin~~ [OpenAPI] Add endpoint for view event details #207 Aug 18, 2024

justinyoo assigned juhangil Aug 18, 2024

justinyoo linked an issue Aug 18, 2024 that may be closed by this pull request

[OpenAPI] Add endpoint for view event details #207

Closed

justinyoo added ossca task openapi labels Aug 18, 2024

justinyoo requested changes Aug 18, 2024

View reviewed changes

juhangil added 2 commits August 18, 2024 22:48

Update GetAdminEventDetails OpenAPI description

7d79152

Update Admin event endpoint files

88974a8

- remove fake implementation in admin event details endpoint - Replace event details url file, EndpointUrls.cs to AdminEndpointUrls.cs - Rename AdminEventDetailsEndpoint.cs to AdminEventEndpoints.cs - Change url route parameter eventID to eventId

justinyoo requested changes Aug 18, 2024

View reviewed changes

src/AzureOpenAIProxy.ApiApp/Endpoints/AdminEventEndpoints.cs Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.ApiApp/Program.cs Outdated Show resolved Hide resolved

juhangil and others added 5 commits August 19, 2024 00:16

Update admin event endpoint

a22f7c8

- AddAdminEventDetails to AddAdminEvents - Replace region to comment

Add some test sample

fac97df

Update name of namespace/class

4a5ea72

Merge pull request #1 from justinyoo/feature/207-endpoint-admin-event…

ea63552

…-details Add admin event api unit test for path

Merge branch 'feature/207-endpoint-admin-event-details' of https://gi…

2e09556

…thub.com/juhangil/azure-openai-sdk-proxy into feature/207-endpoint-admin-event-details

Add aspire host fixture in AppHost xunit test

b4dc2a0

justinyoo requested changes Aug 19, 2024

View reviewed changes

test/AzureOpenAIProxy.AppHost.Tests/Fixture/AspireHostFixture.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.AppHost.Tests/Fixture/AspireHostFixture.cs Outdated Show resolved Hide resolved

Update fixtures namespace

ec7de28

SeungHuLee reviewed Aug 19, 2024

View reviewed changes

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventEventDetailsOpenApiTests.cs Outdated Show resolved Hide resolved

juhangil added 2 commits August 19, 2024 18:22

Rename to AdminGetEventDetailsOpenApiTest

3864299

Add Reponse model and test method

fc6ca77

Update component test method for property check

a67de9d

justinyoo requested changes Aug 19, 2024

View reviewed changes

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventDetailsOpenApiTest.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventDetailsOpenApiTest.cs Outdated Show resolved Hide resolved

juhangil added 2 commits August 20, 2024 00:32

Rename to AdminGetEventDetailsOpenApiTests

845aa33

Update AdminEventDetails comment

fb48e25

justinyoo mentioned this pull request Aug 20, 2024

[Chat Completions] Response payload definition #22 #237

Closed

Update Admin event detail component unit test

9a8d082

justinyoo requested changes Aug 20, 2024

View reviewed changes

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventDetailsOpenApiTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventDetailsOpenApiTests.cs Outdated Show resolved Hide resolved

justinyoo requested changes Aug 20, 2024

View reviewed changes

src/AzureOpenAIProxy.ApiApp/Models/AdminEventDetails.cs Show resolved Hide resolved

justinyoo requested changes Aug 20, 2024

View reviewed changes

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventDetailsOpenApiTests.cs Outdated Show resolved Hide resolved

Update admin event test code style

00073a1

justinyoo requested changes Aug 20, 2024

View reviewed changes

test/AzureOpenAIProxy.AppHost.Tests/ApiApp/Endpoints/AdminGetEventDetailsOpenApiTests.cs Show resolved Hide resolved

Update admin event test package import style

46f2f28

justinyoo approved these changes Aug 20, 2024

View reviewed changes

justinyoo merged commit e63d908 into aliencube:main Aug 20, 2024
1 check passed

justinyoo added the team-kim label Aug 20, 2024

DOZAKA mentioned this pull request Aug 23, 2024

[OpenAPI] Add endpoint for create event details #212 #261

Merged

o-ii mentioned this pull request Sep 14, 2024

[OpenAPI] Add endpoint for create new admin resource details #307 #313

Merged

[OpenAPI] Add endpoint for view event details #207 #231

[OpenAPI] Add endpoint for view event details #207 #231

Uh oh!

Conversation

juhangil commented Aug 18, 2024

Uh oh!

justinyoo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 18, 2024

Test Results

Uh oh!

github-actions bot commented Aug 18, 2024

Test Results

Tests

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Tests

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Tests

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Tests

Uh oh!

Uh oh!

Uh oh!

justinyoo commented Aug 19, 2024

Uh oh!

juhangil commented Aug 19, 2024

Uh oh!

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Tests

Uh oh!

juhangil commented Aug 19, 2024

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Uh oh!

github-actions bot commented Aug 19, 2024

Test Results

Tests

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

justinyoo left a comment

Choose a reason for hiding this comment