Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Support monitoring (dry-run) mode #366

Open
sczyh30 opened this issue Dec 28, 2020 · 3 comments
Open

[RFC] Support monitoring (dry-run) mode #366

sczyh30 opened this issue Dec 28, 2020 · 3 comments
Labels
area/metrics Issue related to metrics and monitoring kind/feature Category issues or PRs related to feature request

Comments

@sczyh30
Copy link
Member

sczyh30 commented Dec 28, 2020

Issue Description

Type: feature request

Describe what feature you want

RFC: Support monitoring (dry-run) mode. In monitoring mode, Sentinel won't actually block the requests, but only record the relevant metrics (for observation). This could be useful when users need to verify whether the rules are appropriate.

@sczyh30 sczyh30 added kind/feature Category issues or PRs related to feature request area/metrics Issue related to metrics and monitoring labels Dec 28, 2020
@louyuting
Copy link
Collaborator

From my perspective, maybe a global config for monitoring mode is enough?

@sczyh30
Copy link
Member Author

sczyh30 commented Dec 28, 2020

Maybe two levels are needed: global level and rule level.
A new kind of metric (like "should block") is required for monitoring mode. More discussions are needed for details (e.g. event propagation, metric logs).

@ansiz
Copy link
Contributor

ansiz commented Sep 3, 2021

I think monitoring mode is necessary.
For production safety, we usually want to configure a monitoring mode rule first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metrics Issue related to metrics and monitoring kind/feature Category issues or PRs related to feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants