fix ci

Author: binbin0325

core/hotspot/rule.go

@@ -15,7 +15,6 @@
 package hotspot
 
 import (
-	"encoding/json"
 	"fmt"
 	"reflect"
 	"strconv"
@@ -101,14 +100,11 @@ type Rule struct {
 }
 
 func (r *Rule) String() string {
-	b, err := json.Marshal(r)
-	if err != nil {
-		// Return the fallback string
-		return fmt.Sprintf("{Id:%s, Resource:%s, MetricType:%+v, ControlBehavior:%+v, ParamIndex:%d, ParamKey:%s, Threshold:%d, MaxQueueingTimeMs:%d, BurstCount:%d, DurationInSec:%d, ParamsMaxCapacity:%d, SpecificItems:%+v}",
-			r.ID, r.Resource, r.MetricType, r.ControlBehavior, r.ParamIndex, r.ParamKey, r.Threshold, r.MaxQueueingTimeMs, r.BurstCount, r.DurationInSec, r.ParamsMaxCapacity, r.SpecificItems)
-	}
-	return string(b)
+	// Return the fallback string
+	return fmt.Sprintf("{Id:%s, Resource:%s, MetricType:%+v, ControlBehavior:%+v, ParamIndex:%d, ParamKey:%s, Threshold:%d, MaxQueueingTimeMs:%d, BurstCount:%d, DurationInSec:%d, ParamsMaxCapacity:%d, SpecificItems:%+v}",
+		r.ID, r.Resource, r.MetricType, r.ControlBehavior, r.ParamIndex, r.ParamKey, r.Threshold, r.MaxQueueingTimeMs, r.BurstCount, r.DurationInSec, r.ParamsMaxCapacity, r.SpecificItems)
 }
+
 func (r *Rule) ResourceName() string {
 	return r.Resource
 }

core/hotspot/rule_manager.go

@@ -83,8 +83,9 @@ func getTrafficControllersFor(res string) []TrafficShapingController {
 
 // LoadRules replaces all old hotspot param flow rules with the given rules.
 // Return value:
-//   bool: indicates whether the internal map has been changed;
-//   error: indicates whether occurs the error.
+//
+//	bool: indicates whether the internal map has been changed;
+//	error: indicates whether occurs the error.
 func LoadRules(rules []*Rule) (bool, error) {
 	resRulesMap := make(map[string][]*Rule, 16)
 	for _, rule := range rules {
@@ -110,7 +111,7 @@ func LoadRules(rules []*Rule) (bool, error) {
 // GetRules returns all the hotspot param flow rules based on copy.
 // It doesn't take effect for hotspot module if user changes the returned rules.
 // GetRules need to compete hotspot module's global lock and the high performance losses of copy,
-// 		reduce or do not call GetRules if possible.
+// reduce or do not call GetRules if possible.
 func GetRules() []Rule {
 	tcMux.RLock()
 	rules := rulesFrom(tcMap)
@@ -126,7 +127,8 @@ func GetRules() []Rule {
 // GetRulesOfResource returns specific resource's hotspot parameter flow control rules based on copy.
 // It doesn't take effect for hotspot module if user changes the returned rules.
 // GetRulesOfResource need to compete hotspot module's global lock and the high performance losses of copy,
-// 		reduce or do not call GetRulesOfResource frequently if possible.
+//
+//	reduce or do not call GetRulesOfResource frequently if possible.
 func GetRulesOfResource(res string) []Rule {
 	tcMux.RLock()
 	resTcs := tcMap[res]

core/stat/base/leap_array.go

@@ -145,11 +145,11 @@ func (aa *AtomicBucketWrapArray) compareAndSet(idx int, except, update *BucketWr
 // Suppose current timestamp is 1188, bucketLength is 200ms, intervalInMs is 1000ms, then
 // time span of current bucket is [1000, 1200). The representation of the underlying structure:
 //
-//   B0       B1      B2     B3      B4
-//   |_______|_______|_______|_______|_______|
-//  1000    1200    400     600     800    (1000) ms
-//         ^
-//      time=1188
+//	 B0       B1      B2     B3      B4
+//	 |_______|_______|_______|_______|_______|
+//	1000    1200    400     600     800    (1000) ms
+//	       ^
+//	    time=1188
 type LeapArray struct {
 	bucketLengthInMs uint32
 	// sampleCount represents the number of BucketWrap.

util/time_test.go

@@ -22,7 +22,7 @@ import (
 	"github.com/stretchr/testify/assert"
 )
 
-//Time zone should be considered for time related operations
+// Time zone should be considered for time related operations
 func TestFormatTimeMillis(t *testing.T) {
 	type args struct {
 		ts uint64