Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8784] fix some bugs for Console UI #8787

Merged
merged 4 commits into from
Jul 25, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Jul 22, 2022

  • add server.error.include-message property
  • add no permission tip when push config
  • use addAllowedOriginPattern instead of addAllowedOrigin
  • remove RAM logic in the lib.js
  • fix button type error and mode value error in NewConfig.js
  • fix the password reset dialog can't show

Close #8784

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

- add server.error.include-message property
- add no permission tip when push config
- use addAllowedOriginPattern instead of addAllowedOrigin
- remove RAM logic in the lib.js
- fix button type error and mode value error in NewConfig.js
- fix the password reset dialog can't show

Close alibaba#8784
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022

Codecov Report

Merging #8787 (cd2f7e1) into develop (8cc92c5) will increase coverage by 0.02%.
The diff coverage is 56.25%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #8787      +/-   ##
=============================================
+ Coverage      43.13%   43.16%   +0.02%     
- Complexity      4689     4693       +4     
=============================================
  Files            903      904       +1     
  Lines          32464    32479      +15     
  Branches        3751     3748       -3     
=============================================
+ Hits           14003    14018      +15     
- Misses         17103    17109       +6     
+ Partials        1358     1352       -6     
Impacted Files Coverage Δ
.../nacos/client/config/impl/ConfigChangeHandler.java 75.00% <ø> (ø)
...om/alibaba/nacos/console/config/ConsoleConfig.java 0.00% <0.00%> (ø)
...in/java/com/alibaba/nacos/core/cluster/Member.java 71.59% <ø> (ø)
...ng/core/v2/metadata/InstanceMetadataProcessor.java 0.00% <0.00%> (ø)
...alibaba/nacos/client/config/impl/ClientWorker.java 54.97% <25.00%> (-0.33%) ⬇️
...om/alibaba/nacos/client/config/impl/CacheData.java 62.68% <39.13%> (-2.02%) ⬇️
...libaba/nacos/client/config/NacosConfigService.java 71.71% <92.30%> (+2.05%) ⬆️
...ess/config/AddressServerSecurityConfiguration.java 100.00% <100.00%> (ø)
...a/nacos/client/naming/cache/ServiceInfoHolder.java 77.19% <100.00%> (+0.67%) ⬆️
...ent/manager/impl/EphemeralIpPortClientManager.java 54.00% <0.00%> (-16.00%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94950a2...cd2f7e1. Read the comment docs.

console-ui/src/locales/en-US.js Outdated Show resolved Hide resolved
console/src/main/resources/application.properties Outdated Show resolved Hide resolved
@KomachiSion KomachiSion merged commit 29d472e into alibaba:develop Jul 25, 2022
@KomachiSion KomachiSion added this to the 2.1.1 milestone Jul 25, 2022
@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug. labels Jul 25, 2022
@onewe onewe deleted the issues/8784 branch July 25, 2022 01:56
beet233 pushed a commit to beet233/nacos that referenced this pull request Jul 25, 2022
* [ISSUE alibaba#8784] fix some bugs for Console UI

- add server.error.include-message property
- add no permission tip when push config
- use addAllowedOriginPattern instead of addAllowedOrigin
- remove RAM logic in the lib.js
- fix button type error and mode value error in NewConfig.js
- fix the password reset dialog can't show

Close alibaba#8784

* [ISSUE alibaba#8784] fix translate error

* [ISSUE alibaba#8784] user ON_PARAM instead of ALWAYS

* [ISSUE alibaba#8784] fix user reset password in the Header.js
onewe added a commit to onewe/nacos that referenced this pull request Aug 17, 2022
KomachiSion pushed a commit that referenced this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are some bugs in the Console UI
4 participants