-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #8784] fix some bugs for Console UI #8787
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add server.error.include-message property - add no permission tip when push config - use addAllowedOriginPattern instead of addAllowedOrigin - remove RAM logic in the lib.js - fix button type error and mode value error in NewConfig.js - fix the password reset dialog can't show Close alibaba#8784
Codecov Report
@@ Coverage Diff @@
## develop #8787 +/- ##
=============================================
+ Coverage 43.13% 43.16% +0.02%
- Complexity 4689 4693 +4
=============================================
Files 903 904 +1
Lines 32464 32479 +15
Branches 3751 3748 -3
=============================================
+ Hits 14003 14018 +15
- Misses 17103 17109 +6
+ Partials 1358 1352 -6
Continue to review full report at Codecov.
|
pixystone
suggested changes
Jul 22, 2022
KomachiSion
approved these changes
Jul 25, 2022
KomachiSion
approved these changes
Jul 25, 2022
KomachiSion
added
area/Nacos console
Related to Nacos consle
kind/bug
Category issues or prs related to bug.
labels
Jul 25, 2022
beet233
pushed a commit
to beet233/nacos
that referenced
this pull request
Jul 25, 2022
* [ISSUE alibaba#8784] fix some bugs for Console UI - add server.error.include-message property - add no permission tip when push config - use addAllowedOriginPattern instead of addAllowedOrigin - remove RAM logic in the lib.js - fix button type error and mode value error in NewConfig.js - fix the password reset dialog can't show Close alibaba#8784 * [ISSUE alibaba#8784] fix translate error * [ISSUE alibaba#8784] user ON_PARAM instead of ALWAYS * [ISSUE alibaba#8784] fix user reset password in the Header.js
onewe
added a commit
to onewe/nacos
that referenced
this pull request
Aug 17, 2022
…into the v1.x Close alibaba#8979
KomachiSion
pushed a commit
that referenced
this pull request
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8784
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
XXXXX
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.