Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8214] Add ldap auth plugin #8216

Merged
merged 3 commits into from
Apr 25, 2022
Merged

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Apr 20, 2022

  • move the config of ldap from NacosAuthConfig to LdapAuthConfig

Close #8214

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@onewe
Copy link
Collaborator Author

onewe commented Apr 20, 2022

@li-xiao-shuang

@onewe
Copy link
Collaborator Author

onewe commented Apr 20, 2022

What a nuisance CI, I will resolve it tomorrow.

- move the config of ldap from NacosAuthConfig to LdapAuthConfig

Close alibaba#8214
@onewe onewe requested a review from KomachiSion April 22, 2022 09:32
@KomachiSion KomachiSion added this to the 2.1.0 milestone Apr 25, 2022
@KomachiSion KomachiSion merged commit 767238e into alibaba:develop Apr 25, 2022
@onewe onewe deleted the issues/8214 branch April 25, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ldap 权限验证失效
2 participants