Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #7487] Add generics for the CacheBuilder. #7490

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

onewe
Copy link
Collaborator

@onewe onewe commented Dec 23, 2021

Close #7487

Add generics for the CacheBuilder:

  • CacheBuilder#builder
  • CacheBuilder#expireNanos

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Apr 27, 2022
@KomachiSion KomachiSion added this to the 2.1.0 milestone Apr 27, 2022
@KomachiSion KomachiSion merged commit 8980a96 into alibaba:develop Apr 27, 2022
@onewe onewe deleted the issues/7487 branch April 27, 2022 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Optimize]add generics for CacheBuilder
3 participants