Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

每次dump任务都在日志里打印出配置加解密的encryptedDataKey #9602

Open
realJackSun opened this issue Nov 18, 2022 · 3 comments
Assignees
Labels
area/Config kind/discussion Category issues related to discussion

Comments

@realJackSun
Copy link
Collaborator

背景

Nacos经常由于encryptedDataKey的缺失引发配置加解密问题,造成事故。
encryptedDataKey的缺失,有时候是由于代码bug,有时候是用户误删除。不管造成的原因怎样,都应该对encryptedDataKey缺失的情况进行观测和监控。

改造方案

对于所有的Dump任务,都在打印日志的时候,打印出来encryptedDataKey。
这样,就可以通过一些日志分析组件,快速的定位到encrytedDatakey为空的情况,并且报警给Nacos的维护者。

@realJackSun
Copy link
Collaborator Author

@i can solve it@
我能解决这个问题

@YunWZ
Copy link
Contributor

YunWZ commented Nov 20, 2022

这是否会存在安全问题,对于信息安全监管有严格要求的场景,也许使用者并不想将密钥输出到日志中。

@KomachiSion KomachiSion added the kind/discussion Category issues related to discussion label Nov 30, 2022
@Daydreamer-ia
Copy link
Contributor

这是否会存在安全问题,对于信息安全监管有严格要求的场景,也许使用者并不想将密钥输出到日志中。

或许可以考虑在一定日志级别下才打印,做成可配置的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/discussion Category issues related to discussion
Projects
None yet
Development

No branches or pull requests

4 participants