Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the orchestration of configuration filters, there are the following areas that can be optimized #9308

Open
CLFutureX opened this issue Oct 12, 2022 · 4 comments
Assignees
Labels
area/Config expired No active for a long time kind/discussion Category issues related to discussion

Comments

@CLFutureX
Copy link
Contributor

For the orchestration of configuration filters, there are the following areas that can be optimized:
1 is not a standard Chain of Responsibility implementation, but is implemented by maintaining an additional set, lacking the embodiment of a chain.
2 An object needs to be created each time.
3 We should encapsulate each configuration filter class as a chain of responsibility node instead of directly using the implementation class as a node.

chinese:
对于配置过滤器的编排,存在以下可以优化的地方:
1 不是标准的责任链实现,而是通过维护一个额外的集合来实现,缺少一个链的体现。
2 每次都需要创建一个对象。
3 我们应该将每个配置过滤器类封装成责任链节点,而不是直接将实现类作为节点。

image

@KomachiSion
Copy link
Collaborator

@yanlinly @shiyiyue1102 @realJackSun I think current implementation is same as the Chain of Responsibility. So I think can be modified. Is there special design about this filter when implementing.

@CLFutureX
Copy link
Contributor Author

@yanlinly @shiyiyue1102 @realJackSun hey , what do you think

@yanlinly
Copy link
Collaborator

can you contact with ding?
this my dingding :wa7tdra

@stale
Copy link

stale bot commented May 21, 2023

Thanks for your feedback and contribution. But the issue/pull request has not had recent activity more than 180 days. This issue/pull request will be closed if no further activity occurs 7 days later.
We may solve this issue in new version. So can you upgrade to newest version and retry?
If there are still issues or want to contribute again. Please create new issue or pull request again.

@stale stale bot added the expired No active for a long time label May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config expired No active for a long time kind/discussion Category issues related to discussion
Projects
None yet
Development

No branches or pull requests

5 participants