Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeregisterInstanceTraceEvent should always hold instance port #8698

Closed
zqq90 opened this issue Jul 7, 2022 · 5 comments
Closed

DeregisterInstanceTraceEvent should always hold instance port #8698

zqq90 opened this issue Jul 7, 2022 · 5 comments

Comments

@zqq90
Copy link

zqq90 commented Jul 7, 2022

Describe the bug

When the heartbeat of an instance times out, it will be deregistered, and a DeregisterInstanceTraceEvent will be published,
However, this event does not hold the port of the instance

Expected behavior

Hold hold instance port, Consistent with 'client initiates request'

See:

Actually behavior

See:

false, DeregisterInstanceReason.HEARTBEAT_EXPIRE, service.getNamespace(), service.getGroup(), service.getName(), instance.getIp()));

@scienceZ
Copy link
Contributor

scienceZ commented Jul 7, 2022

thank you so much for your suggestion,the instanceIp should hold instance port. I will check this problem in all trace module.

@zqq90
Copy link
Author

zqq90 commented Jul 7, 2022

thank you so much for your suggestion,the instanceIp should hold instance port. I will check this problem in all trace module.

The field instanceIp is ambiguous. It is recommended to add a new field, or rename it.

cc @scienceZ

@zqq90
Copy link
Author

zqq90 commented Jul 28, 2022

TO @KomachiSion

The affected functions seem to be newly added in this milestone.
So can this issue catch up with version 2.1.1?

@KomachiSion
Copy link
Collaborator

Has Pr #8805 fixed this problem?

@scienceZ
Copy link
Contributor

scienceZ commented Aug 1, 2022

Has Pr #8805 fixed this problem?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants