Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nacos 2.X client need add async redo feature for failed register/subscribe service. #6384

Closed
KomachiSion opened this issue Jul 19, 2021 · 2 comments · Fixed by #6395
Closed
Assignees
Labels
kind/feature type/feature
Milestone

Comments

@KomachiSion
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

In nacos 2.X client, If register or subscribe service failed, client will throw NacosException out to caller, and help caller to stop the application start.

But some of framework. such as dubbo, will catch the exception and just ignore it then go ahead to do, which will cause application maybe miss the service they register or subscribe.

And we think nacos client throw the NacosException is not problem, but client should add a async redo feature for these register/subscribe failed services.

Describe the solution you'd like
Add a common redo task feature for all service, include register/unregister/subscribe/unsubscribe/reconncetion

@KomachiSion KomachiSion self-assigned this Jul 19, 2021
@KomachiSion KomachiSion added the kind/feature type/feature label Jul 19, 2021
@KomachiSion KomachiSion added this to the 2.0.3 milestone Jul 19, 2021
@KomachiSion
Copy link
Collaborator Author

I plan to implement this feature by wrapper client cache with two status. After call grpc, client should update the cache status. And use another thread to do redo according to the status.

image
image

@Russell4115
Copy link

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature type/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants