Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] update the NamingExample in Nacos 2.x #5689

Closed
brotherlu-xcq opened this issue May 12, 2021 · 4 comments · Fixed by #5924
Closed

[Enhancement] update the NamingExample in Nacos 2.x #5689

brotherlu-xcq opened this issue May 12, 2021 · 4 comments · Fixed by #5924
Assignees
Milestone

Comments

@brotherlu-xcq
Copy link
Collaborator

Describe the bug

naming.registerInstance("nacos.test.3", "2.2.2.2", 9999, "DEFAULT");

update the NamingExample in Nacos 2.x, as we know, Nacos 2.x use grpc connection to bind Client with Server, one Client can only register one Instance. So I think we can update the NamingExample, or else it will confuse the user.

Expected behavior
update the NamingExample

Acutally behavior

How to Reproduce
Steps to reproduce the behavior:
run the NamingExample, you will get no instanse.

Desktop (please complete the following information):

  • OS: [e.g. Centos]
  • Version [2.0.1]
  • Module [example]

Additional context
no

@realJackSun
Copy link
Collaborator

@i will solve it@

@realJackSun
Copy link
Collaborator

This can truely confuse the users

@brotherlu-xcq
Copy link
Collaborator Author

Hi, @JackSun-Developer . How about this issue? if you have no time to do it, I think you can assign it to me. I will try to fix it.

@realJackSun
Copy link
Collaborator

@brotherlu-xcq thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants