-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check namespaceId is exist when some api need namespace to handle #4134
Labels
Comments
If need to check whether namespace is exist, it will depend persistency module first. we may need to discuss and extract the persistency module first |
Maybe we can add a filter in console module to fix it |
And need to cache namespace in memory, and need to maintain the cache. |
I think move it to core module will be better, like authFilter. |
Add a NamespaceFilter like this?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Now I register a instance with the not exist namespaceId. In server,
com.alibaba.nacos.naming.core.ServiceManager
will create a new namesapce, and put service in it.For this situation, we should check the namespaceId is exist. If the situation is not exist, throw an exception.
The text was updated successfully, but these errors were encountered: