Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client/src/main/java/com/alibaba/nacos/client/naming/net/NamingProxy.java has a error #3019

Closed
tomakemyself opened this issue Jun 10, 2020 · 2 comments · Fixed by #3021
Closed

client/src/main/java/com/alibaba/nacos/client/naming/net/NamingProxy.java has a error #3019

tomakemyself opened this issue Jun 10, 2020 · 2 comments · Fixed by #3021
Assignees
@jzdayz
Labels
good first issue Good for newcomers kind/code quality
Milestone
1.3.1

Comments

@tomakemyself
Copy link

Type: code errors

  1. client/src/main/java/com/alibaba/nacos/client/naming/net/NamingProxy.java method public void registerService(String serviceName, String groupName, Instance instance) throws NacosException
    code have a errors should be fixed.

在1. client/src/main/java/com/alibaba/nacos/client/naming/net/NamingProxy.java 类代码里的registerService方法里，定义了一个map：final Map<String, String> params = new HashMap<String, String>(9); 这是一个错误的定义，map的初始容量应该要是2的幂次方，虽然在内部会被强转为2的幂次方，但我们应该严谨的对待，希望官方修复，thank you！
@KomachiSion
Copy link
Collaborator

欢迎提交PR修复这个问题。

@KomachiSion KomachiSion added this to the 1.3.1 milestone Jun 10, 2020
@jzdayz
Copy link
Contributor

jzdayz commented Jun 10, 2020

@i will solve it@

@jzdayz jzdayz mentioned this issue Jun 10, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzdayz jzdayz

Labels
good first issue Good for newcomers kind/code quality
Projects
None yet
Milestone
1.3.1
Development

Successfully merging a pull request may close this issue.

a power of two size for hashmap jzdayz/nacos
3 participants
@tomakemyself @jzdayz @KomachiSion