Fix: unique the route id when nested in the same route path#7135
Open
ClarkXia wants to merge 3 commits intorelease/nextfrom
Open
Fix: unique the route id when nested in the same route path#7135ClarkXia wants to merge 3 commits intorelease/nextfrom
ClarkXia wants to merge 3 commits intorelease/nextfrom
Conversation
XXXMrG
approved these changes
Sep 2, 2025
XGHeaven
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug in the route manifest generation where nested routes with the same path could end up with duplicate or conflicting route IDs. The main fix ensures that route IDs are unique even when nested routes share the same path, by incorporating the parent route's ID into the generated ID. The changes also update the relevant tests and snapshots to reflect the new, more descriptive and unique route IDs.