Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust time display accuracy to milliseconds #2663

Merged
merged 8 commits into from
Sep 20, 2023

Conversation

tianshuang
Copy link
Contributor

When troubleshooting performance issues, sometimes millisecond-level time displays are needed.

@hengyunabc
Copy link
Collaborator

已经升级到 jdk 8,可以改用 DateTimeFormatter 和 LocalDateTime 等。

@tianshuang
Copy link
Contributor Author

已经升级到 jdk 8,可以改用 DateTimeFormatter 和 LocalDateTime 等。

这个 PR 是时间精度调整,不涉及更换格式化相关类

@hengyunabc
Copy link
Collaborator

这个 PR 是时间精度调整,不涉及更换格式化相关类

有改动正好可以用新的 API,并且 DateTimeFormatter 性能更好 。

@tianshuang
Copy link
Contributor Author

这个 PR 是时间精度调整,不涉及更换格式化相关类

有改动正好可以用新的 API,并且 DateTimeFormatter 性能更好 。

已调整为 DateTimeFormatter, com.taobao.arthas.core.shell.impl.ShellImpl 与 com.taobao.arthas.core.shell.system.impl.JobImpl 等类未调整是因为使用了 StringBuilder 调用 toString 生成日期字符串,如果调整为 LocalDateTime 会导致输出的日期字符串格式发生变化。

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tianshuang
❌ hengyunabc
You have signed the CLA already but the status is still pending? Let us recheck it.

@hengyunabc hengyunabc merged commit 2d69300 into alibaba:master Sep 20, 2023
11 checks passed
@hengyunabc hengyunabc added this to the 4.0.0 milestone Sep 20, 2023
tianshuang added a commit to tianshuang/arthas that referenced this pull request Sep 20, 2023
hengyunabc pushed a commit that referenced this pull request Sep 21, 2023
@tianshuang tianshuang deleted the feature_time_display branch July 3, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants