Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support html view for WebUI #1168

Open
kylixs opened this issue May 13, 2020 · 17 comments
Open

Support html view for WebUI #1168

kylixs opened this issue May 13, 2020 · 17 comments
Labels

Comments

@kylixs
Copy link
Contributor

kylixs commented May 13, 2020

At present, a simple WebUI is implemented based on http api, which can only display json data and is not suitable for human reading. We need a text / html view to better display the results of command interaction. It expects to provide a modern operating experience, richer functions, and more flexible scalability.

Build
The http api code will be divided into multiple PRs and merged into the master, which can now be tested and improved on the feature branch.

  1. Checkout termd project, build and install to local repo.
   cd /path/projects/
   git clone https://github.com/alibaba/termd.git
   mvn clean install -Dmaven.test.skip -DskipTests
  1. Checkout the source code of http api, build and package.
   cd /path/projects/
   git clone https://github.com/alibaba/arthas.git
   git checkout http-api
   mvn clean package
  1. Lanuch arthas
    cd /path/projects/arthas
    cd packaging/target/arthas-3.2.1-SNAPSHOT-bin
    java -jar arthas-boot.jar
  1. Visit Arthas WebUI
    Open the browser to visit http://localhost:8563/ui, it is recommended to use chrome
@kylixs
Copy link
Contributor Author

kylixs commented May 14, 2020

@sjha2048
Copy link
Contributor

@kylixs how do I test this pull request on my local machine?

@kylixs
Copy link
Contributor Author

kylixs commented May 20, 2020

@kylixs how do I test this pull request on my local machine?

This http api branch will be merged into arthas in the near future, please use the PR branch for testing now.

@arteevraina
Copy link
Contributor

Hello @kylixs! I am interested in this idea for applying for SoC 2020. Can you guide me how to get started with the repo so that I can start making my proposal?

@arteevraina
Copy link
Contributor

Hello @hengyunabc ! Is there a specific channel for this so that I can start discussing the project idea and ask my doubts regarding the codebase or should I do it through email?

@kylixs
Copy link
Contributor Author

kylixs commented May 26, 2020

@arteevraina The arthas http api branch build step has been added to the content of the issue.
Please join the Arthas discuss group (#1198).

@arteevraina
Copy link
Contributor

arteevraina commented May 26, 2020

@kylixs Thank you very much !

@arteevraina
Copy link
Contributor

@kylixs @hengyunabc I was following the above mentioned steps but while running mvn clean package in arthas directory onhttp-apibranch. I was getting this build failure. Are there any fixes or workarounds for this?
image

@kylixs
Copy link
Contributor Author

kylixs commented Jun 1, 2020

@kylixs @hengyunabc I was following the above mentioned steps but while running mvn clean package in arthas directory onhttp-apibranch. I was getting this build failure. Are there any fixes or workarounds for this?
image

The error details: Failed to delete .../arthas/spy/target/maven-archiver/pom.properties

  1. Please stop the Arthas that have been injected;
  2. Check what process opened the file spy / target / maven-archiver / pom.properties, please close it. You can use the Process Hacker / Process Explorer tool to find the file handle to discover the process of opening the file.
  3. Or just restart the system and rebuild.

@arteevraina
Copy link
Contributor

@kylixs Is http-api that displays data in json format web ui still in development?

@kylixs
Copy link
Contributor Author

kylixs commented Jun 2, 2020

@kylixs Is http-api that displays data in json format web ui still in development?

Yes, the first stage of development is completed and is gradually being merged into the master.
Now you can contribute code, if accepted, it will eventually be merged into the master, but it will take a while.

@kylixs
Copy link
Contributor Author

kylixs commented Jun 9, 2020

@sjha2048 Is the proposal ready? Please submit to the official website of SoC 2020.

@sjha2048
Copy link
Contributor

sjha2048 commented Jun 9, 2020

@kylixs will do by tomorrow evening.

@kylixs
Copy link
Contributor Author

kylixs commented Jun 23, 2020

Some frequently used commands: sm, sc, watch, trace

@sjha2048
Copy link
Contributor

Sure, I'll mention these commands.

@HarshMehta2468
Copy link

@kylixs @hengyunabc I'm really interested in contributing to this idea as a part of Asoc 2020. Will you please guide me as to how should i discuss the project idea so that i can eventually move on towards drafting my proposal?

@kylixs
Copy link
Contributor Author

kylixs commented Jun 24, 2020

@kylixs @hengyunabc I'm really interested in contributing to this idea as a part of Asoc 2020. Will you please guide me as to how should i discuss the project idea so that i can eventually move on towards drafting my proposal?

@HarshMehta2468 Please follow the build steps and feedback if you encounter problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants