Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RT statistic and exception tracing in Sentinel gRPC adapter #995

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Improve RT statistic and exception tracing in Sentinel gRPC adapter #995

merged 1 commit into from
Aug 16, 2019
+195 −403

Conversation

chenledong
Copy link
Contributor

@chenledong chenledong commented Aug 16, 2019 •
edited
Loading

Describe what this PR does / why we need it

Improve RT statistic and exception tracing in Sentinel gRPC adapter.

Does this pull request fix one issue?

Fixes #289

Describe how you did it

  • Override ForwardingClientCall.SimpleForwardingClientCall#cancel for some cases only call cancel.
    • Tracing exception and exit entry.
    • Add entry check for other cases may call both cancel and onClose.

Describe how to verify it

Run the test cases and demo.

Special notes for reviews

None.

@CLAassistant
Copy link

CLAassistant commented Aug 16, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sczyh30 sczyh30 added area/integrations Issues or PRs related to integrations with open-source components kind/enhancement Category issues or prs related to enhancement. labels Aug 16, 2019
@sczyh30 sczyh30 changed the title Enhance process to getting response time and the number of exceptions. Improve RT statistic and exception tracing in Sentinel gRPC adapter Aug 16, 2019
sczyh30
sczyh30 approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit c8df7e7 into alibaba:master Aug 16, 2019
@sczyh30
Copy link
Member

sczyh30 commented Aug 16, 2019

Thanks for contributing!

@sentinel-bot sentinel-bot mentioned this pull request Aug 23, 2019
Closed
@sczyh30 sczyh30 added this to the 1.7.0 milestone Nov 12, 2019
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
@hdchen @ShannonDing
[RIP-10] optimization test case of DefaultMessageStore (alibaba#995)
ede33c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sczyh30 sczyh30 sczyh30 approved these changes

Assignees
No one assigned
Labels
area/integrations Issues or PRs related to integrations with open-source components kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

[Bug] grpc adapter-Tracer.trace() can't success
3 participants
@chenledong @CLAassistant @sczyh30