-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw the original exception when fallback or blockHandler method is invoked in annotation support #986
Conversation
Hi, could you please sign the CLA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a test case for your case?
And you could sync with the latest |
OK, I will improve this pr. |
Hi, any progress? :) |
Friendly ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[RIP-9] Remove unnecessary dots for Design_Trancation.md
AbstractSentinelAspectSupport#handleFallback
should throw original Exception rather thanInvocationTargetException
.Does this pull request fix one issue?
Fixes #985
Describe how you did it
Describe how to verify it
run all Tests in sentinel-annotation-aspectj/src/test/java/com.alibaba.csp.sentinel.annotation.aspectj`.