Improve the edit dialog for FlowRule and ParamFlowRule in Sentinel dashboard #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add duration configuration support for ParamFlowRule - Some other enhancements Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added
to-review
Codecov Report
@@ Coverage Diff @@
## master #845 +/- ##
============================================
+ Coverage 41.73% 42.12% +0.38%
- Complexity 1383 1399 +16
============================================
Files 305 305
Lines 8807 8853 +46
Branches 1188 1203 +15
============================================
+ Hits 3676 3729 +53
+ Misses 4677 4672 -5
+ Partials 454 452 -2
Continue to review full report at Codecov.
|
...main/java/com/alibaba/csp/sentinel/dashboard/datasource/entity/rule/ParamFlowRuleEntity.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
cdfive
reviewed
Jun 17, 2019
sentinel-dashboard/src/main/webapp/resources/app/scripts/controllers/param_flow.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eric Zhao sczyh16@gmail.com
Describe what this PR does / why we need it
Improve the edit dialog for FlowRule and ParamFlowRule in Sentinel dashboard.
Does this pull request fix one issue?
NONE
Describe how you did it
durationInSecandfallbackToLocalWhenFailconfiguration support for ParamFlowRuleDescribe how to verify it
Run the dashboard.
Special notes for reviews
NONE