Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the parameter flow module and refactor API gateway adapter common module #758

Merged
merged 4 commits into from
May 22, 2019
Merged

Improve the parameter flow module and refactor API gateway adapter common module #758

merged 4 commits into from
May 22, 2019

Commits on May 11, 2019

  1. Refactor FlowRuleChecker to improve code reuse 

    Signed-off-by: Eric Zhao <sczyh16@gmail.com>
    @sczyh30
    sczyh30 committed May 11, 2019
    Configuration menu
    Copy the full SHA
    9fe291c View commit details
    Browse the repository at this point in the history

  2. Separate parameter metric storage from ParamFlowSlot and improve Para… 

    …mFlowRuleUtil

- Add a ParameterMetricStorage specific for caching ParameterMetric (moved from ParamSlot)
- Add rule map building helper method in ParamFlowRuleUtil so that we can reuse it in other rule managers

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
    @sczyh30
    sczyh30 committed May 11, 2019
    Configuration menu
    Copy the full SHA
    1efdb6a View commit details
    Browse the repository at this point in the history

  3. Refactor API gateway common module to separate converted rules from o… 

    …ther rule managers

- Separate converted parameter rules from ParamFlowManager. Now the converted rules will be kept in GatewayRuleManager directly.
- Add a GatewayFlowSlot to do separate flow checking for generated rules.
- Refactor rule converting mechanism: now gateway rules in normal mode (without parameter) will also be converted to a parameter flow rule. The index will be the last (the last position). In GatewayParamParser we put a constant value to the last position.

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
    @sczyh30
    sczyh30 committed May 11, 2019
    Configuration menu
    Copy the full SHA
    7f2e98b View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Fix the bug for parsing with only non-param gateway rules 

    Signed-off-by: Eric Zhao <sczyh16@gmail.com>
    @sczyh30
    sczyh30 committed May 21, 2019
    Configuration menu
    Copy the full SHA
    6e794b8 View commit details
    Browse the repository at this point in the history