Add cpu usage and system load to metric #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carpenter Lee <hooleeucas@163.com>
CarpenterLee
changed the title
CarpenterLee
added
the
area/metrics
This was referenced May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carpenter Lee hooleeucas@163.com
Describe what this PR does / why we need it
Sentinel metric only provides metrics of every resource. But CPU usage and system load are also important indicators of the current machine.
Does this pull request fix one issue?
NONE
Describe how you did it
Add CPU usage and system load to the metric list when doing metric fetch. We do not store the CPU usage and system load to metric file, but only add them to the metric list that returned when doing metric fetch.
Describe how to verify it
Code review
Special notes for reviews