Fix the NPE bug when passing null args and paramIdx is negative #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also rearrangement of some code Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #642 +/- ##
============================================
+ Coverage 40.06% 40.57% +0.51%
- Complexity 1293 1307 +14
============================================
Files 284 284
Lines 8916 8919 +3
Branches 1192 1192
============================================
+ Hits 3572 3619 +47
+ Misses 4887 4835 -52
- Partials 457 465 +8
Continue to review full report at Codecov.
|
blindpirate
pushed a commit
to blindpirate/Sentinel
that referenced
this pull request
Apr 10, 2019
…s negative (alibaba#642) - Also rearrangement of some code Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added a commit
that referenced
this pull request
Apr 17, 2019
…s negative (#642) - Also rearrangement of some code Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Fix the NPE bug when passing null args to
SphU.entry(xxx, args)andparamIdxof parameter flow rule is negative (< 0).Does this pull request fix one issue?
Fixes #643
Describe how you did it
Check null args in
checkParams. Also rearrange some code inParamFlowSlot.Describe how to verify it
Run the test cases.
Special notes for reviews
NONE