Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the field name flowRulesKey in ApolloDataSource #593

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Improve the field name flowRulesKey in ApolloDataSource #593

merged 1 commit into from
Mar 20, 2019

Conversation

lawrencewu
Copy link
Contributor

Describe what this PR does / why we need it
This PR is used to correct the field name flowRulesKey and defaultFlowRuleValue in ApolloDataSource to enhence readable.

Does this pull request fix one issue?
Fixed #590

Describe how you did it
Describe how to verify it
Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Mar 19, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

Merging #593 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #593      +/-   ##
===========================================
- Coverage     39.86%   39.8%   -0.06%     
+ Complexity     1244    1243       -1     
===========================================
  Files           275     275              
  Lines          8702    8702              
  Branches       1163    1163              
===========================================
- Hits           3469    3464       -5     
- Misses         4785    4793       +8     
+ Partials        448     445       -3
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/Striped64.java 61.45% <0%> (-5.21%) 11% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LongAdder.java 34.04% <0%> (ø) 11% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cda4f7e...d71d131. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Mar 20, 2019
@sczyh30
Copy link
Member

sczyh30 commented Mar 20, 2019

Hi, thanks for contributing. Could you please sign the CLA here? And please make sure the email of your commits match your GitHub email.


感谢贡献,请将 commit 对应的 email 调整成与 GitHub 的 email 相匹配并 确认一下 CLA

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 9051a6b into alibaba:master Mar 20, 2019
@sczyh30
Copy link
Member

sczyh30 commented Mar 20, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the field name "flowRulesKey" in ApolloDataSource
4 participants