Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save total inbound traffic in metric file #555

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

CarpenterLee
Copy link
Contributor

Signed-off-by: Carpenter Lee hooleeucas@163.com

Describe what this PR does / why we need it

Basically, invocation can be inbound or outbound, and total inbound traffic is an important system overall indicator. Sentinel Constants.ENTRY_NODE has counted all inbound traffics for SystemRule, it will be useful to save it out to metric file.

Does this pull request fix one issue?

NONE

Describe how you did it

Sentinel Constants.ENTRY_NODE has counted all inbound traffics for SystemRule. We write out the metric every one second to metric file.

Describe how to verify it

Run test cases.

Special notes for reviews

Signed-off-by: Carpenter Lee <hooleeucas@163.com>
@sczyh30 sczyh30 added the to-review To review label Mar 8, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 341b642 into master Mar 11, 2019
@sczyh30
Copy link
Member

sczyh30 commented Mar 11, 2019

Maybe we can add a property to control whether to enable this feature later :)

@sczyh30 sczyh30 deleted the feature/save_total_inbound_traffic_in_metric_file branch March 11, 2019 10:26
@sczyh30 sczyh30 removed the to-review To review label Mar 11, 2019
@sczyh30 sczyh30 added this to the 1.5.0 milestone Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants