Fix concurrent error in InMemoryMetricsRepository of the dashboard #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fix edit rule issue when cancel (#370) - Make fallbackToLocalWhenFail of cluster rules configurable in dashboard - Fix edit rule when hit cancel button (object share problem solved by deep copy) - Add metric table td header's title for friendly prompt info
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…g description Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- implement `SentinelPreFilter`, `SentinelPostFilter` and `SentinelErrorFilter` - support fallback
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…WarmUpRateLimiterController Signed-off-by: Carpenter Lee <hooleeucas@163.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Carpenter Lee <hooleeucas@163.com>
… ClassNotFoundException thrown by Nacos client (#438)
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…r when loading SPI Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…text in Tracer Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
…#465) - reuse old map size to avoid rearrange and rehash the map
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- Apply awaitility to core tests - Cache maven local repo in Travis
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
… and add basic test cases Signed-off-by: Eric Zhao <sczyh16@gmail.com>
* Extract getRule in BlockException and refine override methods in subclasses Signed-off-by: Eric Zhao <sczyh16@gmail.com>
- The NPE will occur when multiple threads are trying to create the connection group for the same namespace Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
同步远程仓库最近代码
fix ConcurrentModificationException of listResourcesOfApp method
Codecov Report
@@ Coverage Diff @@
## master #488 +/- ##
============================================
+ Coverage 40.72% 40.75% +0.02%
- Complexity 1095 1097 +2
============================================
Files 236 236
Lines 7570 7570
Branches 1050 1050
============================================
+ Hits 3083 3085 +2
+ Misses 4090 4088 -2
Partials 397 397
Continue to review full report at Codecov.
|
sczyh30
changed the title
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
fix the ConcurrentModificationException of InMemoryMetricsRepository
Does this pull request fix one issue?
Fixes #433
Describe how you did it
replace LinkedHashMap with ConcurrentLinkedHashMap of google code
Describe how to verify it
run the test case of InMemoryMetricsRepository
Special notes for reviews