Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nacos namespace demo and update nacos-sdk version #474

Merged
merged 1 commit into from
Jan 31, 2019

Conversation

yanlinly
Copy link
Collaborator

Describe what this PR does / why we need it

update nacos namespace demo and update nacos-sdk version to 0.8.0 (pre-ga version), so that more stable, and learn namespace feature.

Does this pull request fix one issue?

no

Describe how you did it

update demo

Describe how to verify it

run this demo

Special notes for reviews

you can learn how to use namespace by this demo

@yanlinly yanlinly added the kind/enhancement Category issues or prs related to enhancement. label Jan 30, 2019
@yanlinly yanlinly added this to the 1.4.2 milestone Jan 30, 2019
@yanlinly yanlinly requested a review from sczyh30 January 30, 2019 14:23
@codecov-io
Copy link

codecov-io commented Jan 30, 2019

Codecov Report

Merging #474 into master will increase coverage by 0.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #474      +/-   ##
============================================
+ Coverage      39.4%   40.01%   +0.61%     
- Complexity     1058     1072      +14     
============================================
  Files           236      236              
  Lines          7538     7538              
  Branches       1049     1049              
============================================
+ Hits           2970     3016      +46     
+ Misses         4187     4130      -57     
- Partials        381      392      +11
Impacted Files Coverage Δ Complexity Δ
...s/block/flow/controller/RateLimiterController.java 79.31% <0%> (-10.35%) 7% <0%> (-1%)
...a/csp/sentinel/slots/statistic/base/LongAdder.java 36.17% <0%> (+19.14%) 12% <0%> (+8%) ⬆️
...a/csp/sentinel/slots/statistic/base/Striped64.java 67.7% <0%> (+41.66%) 12% <0%> (+7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f27d7a4...4b096e0. Read the comment docs.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 1368154 into alibaba:master Jan 31, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 31, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants