HashMap init optimize when adding new ClusterNode to cluster node map #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
============================================
- Coverage 37.66% 37.62% -0.05%
+ Complexity 983 982 -1
============================================
Files 235 235
Lines 7429 7429
Branches 1017 1017
============================================
- Hits 2798 2795 -3
- Misses 4271 4273 +2
- Partials 360 361 +1
Continue to review full report at Codecov.
|
kun-song
suggested changes
Jan 27, 2019
| @@ -81,7 +81,7 @@ public void entry(Context context, ResourceWrapper resourceWrapper, DefaultNode | |||
| if (clusterNode == null) { | |||
| // Create the cluster node. | |||
| clusterNode = Env.nodeBuilder.buildClusterNode(); | |||
| HashMap<ResourceWrapper, ClusterNode> newMap = new HashMap<ResourceWrapper, ClusterNode>(16); | |||
| HashMap<ResourceWrapper, ClusterNode> newMap = new HashMap<ResourceWrapper, ClusterNode>(Math.max(clusterNodeMap.size(), 16)); | |||
There was a problem hiding this comment.
First, we can use type inference instead of explicit type parameter here:
new HashMap<>(...);Second, the initial size should be the max of (int) clusterNodeMap.size() / 0.75 + 1 and 16.
|
Hi, could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=465 |
sczyh30
changed the title
sczyh30
approved these changes
Jan 28, 2019
|
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
NONE
Describe how you did it
use old hash map size init new hash map size.
Describe how to verify it
checked
Special notes for reviews