Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dashboard package name from com.taobao to com.alibaba #435

Merged
merged 1 commit into from
Jan 21, 2019

Conversation

CarpenterLee
Copy link
Contributor

Signed-off-by: Carpenter Lee hooleeucas@163.com

Describe what this PR does / why we need it

Rename dashboard package name from com.taobao to com.alibaba.

Does this pull request fix one issue?

none.

Describe how you did it

Rename dashboard package name from com.taobao to com.alibaba.

Describe how to verify it

Start dashboard to check it.

Special notes for reviews

none.

Signed-off-by: Carpenter Lee <hooleeucas@163.com>
@codecov-io
Copy link

codecov-io commented Jan 21, 2019

Codecov Report

Merging #435 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #435      +/-   ##
============================================
+ Coverage     37.69%   37.76%   +0.06%     
- Complexity      981      983       +2     
============================================
  Files           235      235              
  Lines          7409     7409              
  Branches       1016     1016              
============================================
+ Hits           2793     2798       +5     
+ Misses         4254     4251       -3     
+ Partials        362      360       -2
Impacted Files Coverage Δ Complexity Δ
...a/csp/sentinel/slots/statistic/base/LeapArray.java 68.35% <0%> (+6.32%) 24% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a5225...cac3117. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Jan 21, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Jan 21, 2019
@CarpenterLee CarpenterLee merged commit 88fd74c into master Jan 21, 2019
@sczyh30 sczyh30 removed the to-review To review label Jan 21, 2019
@sczyh30 sczyh30 deleted the dashboard/rename_package branch January 21, 2019 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard Issues or PRs about Sentinel Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants