Skip to content

Conversation

@sczyh30
Copy link
Member

@sczyh30 sczyh30 commented Jan 4, 2019

Describe what this PR does / why we need it

Add total QPS limit control for specific namespace in cluster flow control, so that it won't surge indefinitely and affect user's service itself in embedded server mode.

Does this pull request fix one issue?

Resolves #381

Describe how you did it

  • Add UnaryLeapArray and RequestLimiter to enable simple QPS limit
  • Improve cluster rule manager and server config manager to support request limiter
  • Support TOO_MANY_REQUEST status in client side
  • Also improve the automatic namespace register of embedded server mode

Describe how to verify it

See test cases.

Special notes for reviews

NONE

- Also improve the automatic namespace register of embedded server mode

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Signed-off-by: Eric Zhao <sczyh16@gmail.com>
@sczyh30 sczyh30 added the to-review To review label Jan 4, 2019
Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 99bdb9c into master Jan 4, 2019
@sczyh30 sczyh30 deleted the feature/cluster-qps-limiter branch January 4, 2019 06:18
@sczyh30 sczyh30 removed the to-review To review label Jan 4, 2019
Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
…ntrol (alibaba#382)

- Add `UnaryLeapArray` and `RequestLimiter` to enable simple QPS limit
- Improve cluster rule manager and server config manager to support request limiter
- Support `TOO_MANY_REQUEST` status in client side
- Also improve the automatic namespace register of embedded server mode

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support total QPS limit control for specific namespace in cluster flow control

3 participants