Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add healthCount/total for dashboard sidebar #376

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

jz0630
Copy link
Contributor

@jz0630 jz0630 commented Jan 2, 2019

Does this pull request fix one issue?

#17

@jz0630
Copy link
Contributor Author

jz0630 commented Jan 2, 2019

代码学习心得

  1. 接入控制台的服务,定期上报心跳给控制台,间隔时间可设定,默认5秒,simple-http默认10秒
  2. 服务节点5分钟没有上报心跳,会被判定离线

控制台优化

在目录树服务名称右侧,增加(健康数/总数)信息,如果健康数为0,则不现实该服务

讨论点

  • 是否需要增加开关,确定健康数为0的服务,是否要显示?
  • 是否要增加配置,修改5分钟离线判定?

@codecov-io
Copy link

Codecov Report

Merging #376 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #376   +/-   ##
=========================================
  Coverage     38.39%   38.39%           
  Complexity      940      940           
=========================================
  Files           218      218           
  Lines          6969     6969           
  Branches        947      947           
=========================================
  Hits           2676     2676           
  Misses         3955     3955           
  Partials        338      338

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832d6e4...c1c0c05. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Jan 3, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 8970f53 into alibaba:master Jan 7, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 7, 2019

Nice, thanks for your contribution!

@sczyh30
Copy link
Member

sczyh30 commented Jan 7, 2019

代码学习心得

  1. 接入控制台的服务,定期上报心跳给控制台,间隔时间可设定,默认5秒,simple-http默认10秒
  2. 服务节点5分钟没有上报心跳,会被判定离线

控制台优化

在目录树服务名称右侧,增加(健康数/总数)信息,如果健康数为0,则不现实该服务

讨论点

  • 是否需要增加开关,确定健康数为0的服务,是否要显示?
  • 是否要增加配置,修改5分钟离线判定?

增加开关,健康数为 0 的服务是否显示:这个很有用,可以加的

@sczyh30
Copy link
Member

sczyh30 commented Jan 7, 2019

在应用名长度比较大的时候显示有一些错位,有时间可以再提个 PR 修复一下哈:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants