Add global fallback support for AspectJ annotation extension #3383
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 1.8 #3383 +/- ##
============================================
+ Coverage 45.89% 45.96% +0.07%
- Complexity 2145 2152 +7
============================================
Files 431 432 +1
Lines 12903 12926 +23
Branches 1727 1728 +1
============================================
+ Hits 5922 5942 +20
- Misses 6279 6283 +4
+ Partials 702 701 -1
☔ View full report in Codecov by Sentry. |
| * If no specific global fallback handler is provided, the default {@link DefaultGlobalFallback} class will be used. | ||
| * @return The class that serves as the global fallback handler. | ||
| */ | ||
| Class<? extends IGlobalFallback> globalFallback() default DefaultGlobalFallback.class; |
There was a problem hiding this comment.
IMO, the scenario the related issue(#3110) aims to solve is to have a global fallback even when neither fallback nor defaultFallback is configured in the annotations. So, the global fallback should be configured in the construction method of SentinelResourceAspect, rather than through annotations (like what defaultFallback did).
| @@ -53,6 +53,25 @@ public String fooWithFallback(int i) throws Exception { | |||
| return "Hello for " + i; | |||
| } | |||
|
|
|||
| @SentinelResource(value = "apiFooWithFallback", globalFallback = AnnotationGlobalFallback.class, | |||
There was a problem hiding this comment.
If convenient, could you please add relevant example code in the sentinel-demo-annotation-spring-aop module?
LearningGp
added
to-review
Describe what this PR does / why we need it
Add global fallback support for AspectJ annotation extension
Does this pull request fix one issue?
Fixes #3110
Describe how you did it
add global fallback interface and let it as the member of @SentinelResource,
cache and call the global fallback instance in the aspect when origin method throws Throwable
Describe how to verify it
Use unit test to verify the correctness
Special notes for reviews
NONE