add some unit test for sentinel-transport-netty-http module #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
The
sentinel-transport-netty-http
module doesn't have test package, add some unit test.Does this pull request fix one issue?
NONE
Describe how you did it
Import
junit
andmockito-core
dependency, and use Netty'sEmbeddedChannel
for test ChannelHandler.Describe how to verify it
run mvn test
Special notes for reviews
one test case
testGetRuleCommandFlowSomeRules
, since I haven't found a good way yet,comment the@Test
annotation and marked it with theFIXME
comment, for improving it in the future.