Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CopyOnWriteArraySet for ConnectionGroup#connectionSet to avoid iterator fast-fail #2559

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

Roger3581321
Copy link
Contributor

Describe what this PR does / why we need it

利用 CopyOnWriteArraySet解决并发修改会存在集合快速失败问题

Does this pull request fix one issue?

参考PR#2519

Describe how you did it

使用CopyOnWriteArraySet

@sczyh30 sczyh30 added area/cluster-flow Issues or PRs related to cluster flow control kind/bug Category issues or prs related to bug. labels Feb 7, 2022
@sczyh30 sczyh30 changed the title 将connectionSet更改为CopyOnWriteArraySet Use CopyOnWriteArraySet for ConnectionGroup#connectionSet to avoid iterator fast-fail Feb 7, 2022
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 added this to the 1.8.4 milestone Feb 7, 2022
@sczyh30 sczyh30 merged commit ca13ea6 into alibaba:master Feb 7, 2022
@sczyh30
Copy link
Member

sczyh30 commented Feb 7, 2022

Thanks for contributing!

Zhang-0952 pushed a commit to Zhang-0952/Sentinel that referenced this pull request Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-flow Issues or PRs related to cluster flow control kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants