Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add abstract Sentinel aspect class for extension #214

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Add abstract Sentinel aspect class for extension #214

merged 1 commit into from
Oct 31, 2018

Conversation

bitonly
Copy link
Contributor

@bitonly bitonly commented Oct 31, 2018

Describe what this PR does / why we need it

add abstract sentinel aspect for extension

Does this pull request fix one issue?

Fixes #212

Describe how you did it

add new abstract class AbstractSentinelAspect , then SentinelResourceAspect extend it

Describe how to verify it

Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2018

CLA assistant check
All committers have signed the CLA.

@sczyh30 sczyh30 added the to-review To review label Oct 31, 2018
@sczyh30
Copy link
Member

sczyh30 commented Oct 31, 2018

Hi, thanks for contributing. Please sign the CLA and make sure the email of your commits match your GitHub account.

@sczyh30 sczyh30 changed the title Feature/20181031 change aspect Add abstract Sentinel aspect class for extension Oct 31, 2018
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit cb09304 into alibaba:master Oct 31, 2018
@sczyh30
Copy link
Member

sczyh30 commented Oct 31, 2018

👍

@sczyh30 sczyh30 removed the to-review To review label Oct 31, 2018
sczyh30 pushed a commit that referenced this pull request Dec 25, 2018
Arlmls pushed a commit to Arlmls/Sentinel that referenced this pull request Jan 8, 2019
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentinelResourceAspect类继承问题
3 participants