Skip to content

Conversation

@brotherlu-xcq
Copy link
Collaborator

Describe what this PR does / why we need it

LoginAuthenticationFilter authFilterExcludeUrls match supports uri like /xx/**

Does this pull request fix one issue?

Fixs #1967

Describe how you did it

add the org.springframework.util.AntPathMatcher to support matching the uri like /xx/**

Describe how to verify it

request the exclude urls

Special notes for reviews

@sczyh30 sczyh30 requested a review from cdfive January 19, 2021 02:33
@sczyh30 sczyh30 added the area/dashboard Issues or PRs about Sentinel Dashboard label Jan 19, 2021
@cdfive
Copy link
Collaborator

cdfive commented Jan 19, 2021

Good method! How about we apply this new feature?
In application.properties: auth.filter.exclude-urls=/,/auth/login,/auth/logout,/registry/machine,/version
/auth/login,/auth/logout seems can reduced to /auth/* or /auth/**, both are ok.
the other url/auth/check can be accessed without login.

@brotherlu-xcq
Copy link
Collaborator Author

it seems can not work ideal with the current excludeUrls, we can keep this feature not change the properties auth.filter.exclude-urls. maybe this feature can be apply to the new excludeUrls in the future.

Copy link
Collaborator

@cdfive cdfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing and provide this new feature!

@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Jan 27, 2021
@sczyh30 sczyh30 added this to the 1.8.1 milestone Jan 27, 2021
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit b7546c8 into alibaba:master Jan 27, 2021
@sczyh30
Copy link
Member

sczyh30 commented Jan 27, 2021

Thanks for contributing and look forward to more!

@brotherlu-xcq brotherlu-xcq deleted the feature-#1967 branch January 28, 2021 06:39
shenbaoyong pushed a commit to shenbaoyong/Sentinel that referenced this pull request Feb 5, 2021
hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 2, 2021
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 14, 2021
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 14, 2021
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 15, 2021
linkolen pushed a commit to shivagowda/Sentinel that referenced this pull request Aug 15, 2021
CST11021 pushed a commit to CST11021/Sentinel that referenced this pull request Nov 3, 2021
[ISSUE alibaba#1971] Fix ConsumerFilterManager comment error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dashboard Issues or PRs about Sentinel Dashboard kind/enhancement Category issues or prs related to enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

建议LoginAuthenticationFilter 属性authFilterExcludeUrls配置支持uri: /xx/**

3 participants