-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logic of StatisticNode#maxSuccessQps #1196
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
===========================================
+ Coverage 43.01% 43.1% +0.08%
- Complexity 1570 1572 +2
===========================================
Files 337 337
Lines 9877 9878 +1
Branches 1332 1332
===========================================
+ Hits 4249 4258 +9
+ Misses 5100 5094 -6
+ Partials 528 526 -2
Continue to review full report at Codecov.
|
Could you please sign the CLA here: https://cla-assistant.io/alibaba/Sentinel?pullRequest=1196 |
@sczyh30 CLA signed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for contributing! |
Describe what this PR does / why we need it
StatisticNode#maxSuccessQps returns maxSuccess of sliding windows, it should divide the window's interval to get correct QPS result
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews