Refactor: Get the max allowed RT directly from SentinelConfig.statisticMaxRt() #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to avoid the dependency chain: Constants -> SentinelConfig Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added
the
kind/enhancement
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
===========================================
+ Coverage 42.78% 42.8% +0.01%
Complexity 1538 1538
===========================================
Files 330 330
Lines 9764 9767 +3
Branches 1318 1319 +1
===========================================
+ Hits 4178 4181 +3
+ Misses 5069 5068 -1
- Partials 517 518 +1
Continue to review full report at Codecov.
|
hughpearse
pushed a commit
to hughpearse/Sentinel
that referenced
this pull request
Jun 2, 2021
…icMaxRt() (alibaba#1173) - to avoid the dependency chain: Constants -> SentinelConfig Signed-off-by: Eric Zhao <sczyh16@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Get the max allowed RT directly from
SentinelConfig.statisticMaxRt(), to avoid the class dependency chain:Constants -> SentinelConfig. TheConstantsclass should not depend on any classes that could trigger static initialization.Does this pull request fix one issue?
NONE
Describe how you did it
TIME_DROP_VALUEinConstantsclass (which was resolved withSentinelConfig.statisticMaxRt())SentinelConfig.statisticMaxRt()Describe how to verify it
Run the test cases.
Special notes for reviews
NONE