Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Degrade by exception count #173

Closed
CarpenterLee opened this issue Oct 11, 2018 · 0 comments · Fixed by #174
Closed

Degrade by exception count #173

CarpenterLee opened this issue Oct 11, 2018 · 0 comments · Fixed by #174
Labels
kind/feature Category issues or prs related to feature request.
Milestone
1.3.0

Comments

@CarpenterLee
Copy link
Contributor

CarpenterLee commented Oct 11, 2018 •
edited
Loading

Issue Description

Type: feature request

Describe what happened (or what feature you want)

DegradeRule only have two type now, one is by RT, the other is by exception ratio. Degrade by exception count is not supported, which is necessary in the real case.

Describe what you expected to happen

Add a new DegradeRule type, degrade by exception count in the last minute. Degradation will be triggered if exception count in the last minute greats than or equals to the threshold.

How to reproduce it (as minimally and precisely as possible)

None

Tell us your environment

None

Anything else we need to know?

None
@CarpenterLee CarpenterLee added the kind/feature Category issues or prs related to feature request. label Oct 11, 2018
@CarpenterLee CarpenterLee mentioned this issue Oct 11, 2018
Merged
@sczyh30 sczyh30 added this to the 0.2.1 milestone Oct 11, 2018
CST11021 pushed a commit to CST11021/Sentinel that referenced this issue Nov 3, 2021
@zhouxinyu
Fix random int bug in SelectMessageQueueByRandom
e1a42e4 
Author: 释一 <quanwei.lqw@alibaba-inc.com>

Closes alibaba#173 from swwlqw/master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Category issues or prs related to feature request.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Support degrade by exception count alibaba/Sentinel
2 participants
@sczyh30 @CarpenterLee