Skip to content

add-github-actions-support #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Node.js CI

on:
push:
branches: [ master ]
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [10.x, 12.x, 14.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: cp .env.example .env
- run: source .env
- run: npm run build --if-present
- run: npm run lint --if-present
- run: npm test --if-present
2 changes: 1 addition & 1 deletion app.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ mongoose.connect(MONGODB_URL, {useNewUrlParser: true, useUnifiedTopology: true }
process.exit(1);
});

var db = mongoose.connection;

var app = express();
//don't show the log when it is test
if(process.env.NODE_ENV !== "test") {
Expand Down
2 changes: 0 additions & 2 deletions controllers/AuthController.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,8 @@ const { body,validationResult } = require("express-validator");
const { sanitizeBody } = require("express-validator");
//helper file to prepare responses.
const apiResponse = require("../helpers/apiResponse");
const utility = require("../helpers/utility");
const bcrypt = require("bcrypt");
const jwt = require("jsonwebtoken");
const { constants } = require("../helpers/constants");

/**
* User registration.
Expand Down
236 changes: 0 additions & 236 deletions controllers/DeviceController.js

This file was deleted.

1 change: 0 additions & 1 deletion routes/api.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,5 @@ var app = express();

app.use("/auth/", authRouter);
app.use("/book/", bookRouter);
app.use("/device/", deviceRouter);

module.exports = app;
12 changes: 0 additions & 12 deletions routes/device.js

This file was deleted.

5 changes: 3 additions & 2 deletions test/auth.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { chai, server, should } = require("./testConfig");
const { chai, server } = require("./testConfig");
const UserModel = require("../models/UserModel");

/**
Expand All @@ -14,7 +14,8 @@ describe("Auth", () => {

// Before each test we empty the database
before((done) => {
UserModel.deleteMany({}, (err) => {
UserModel.deleteMany({}, (err) => {
console.log(err)
done();
});
});
Expand Down
3 changes: 2 additions & 1 deletion test/book.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { chai, server, should } = require("./testConfig");
const { chai, server } = require("./testConfig");
const BookModel = require("../models/BookModel");

/**
Expand All @@ -16,6 +16,7 @@ describe("Book", () => {
//Before each test we empty the database
before((done) => {
BookModel.deleteMany({}, (err) => {
console.log(err)
done();
});
});
Expand Down