fix(prompt): warn when custom template directory doesn't exist #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Previously, template_dir in config was resolved relative to the current working directory (CWD), making configs non-portable and dependent on where the command was run from. Now template_dir is resolved relative to the config file's location, allowing users to specify relative paths that work regardless of CWD. - Relative paths are converted to absolute based on config file directory - Absolute paths remain unchanged - Path normalization handles .. and . components correctly - Added comprehensive test suite covering all path resolution scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the logic in the
__init__method to log a warning if the specified custom template directory does not exist.