fix: patch algosdk so deleted applications can be fetched #454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lempira
approved these changes
Jun 26, 2025
Contributor
lempira
left a comment
lempira
left a comment
There was a problem hiding this comment.
TIL 💡 - the patching system
Contributor
Author
@lempira Yeah |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #455
When trying to load an application that has been deleted, the following error is returned "Error: Application failed to load". This is due to the algosdk@3 indexer client not handling the null approval and clear program which is returned when the application is deleted.
This PR monkey patches algosdk to convert any null or undefined bytes value it encounters when deserialising JSON into empty bytes value.
An upstream PR to algosdk has been created algorand/js-algorand-sdk#991