Update the template to expose the response context #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aorumbayev
approved these changes
May 2, 2025
aorumbayev
added a commit
that referenced
this pull request
May 6, 2025
chore: adding more structure to api folder; automating generation of py|ts clients chore: refining stock template to leverage pytest over unittest and auto generate valid baseline tests chore: removing auto generated tests as they are too cumbersome to modify - Instead setting up a structure for custom mustache files implementing manually written tests given that each end point (total around 55) often requires complex state setup - For the time being the only test established is the test for sending raw transactions chore: refining base python tests; fixing typescript template chore: add basic txn params tests chore: refine python transaction tests chore: typescript client tweaks and initial tests docs: initial doc on api folder and oas generators chore: adding default pr and issue templates chore: refning docs chore: moving python ffi improvements to separate pr; adding basic ci for oas clients chore: expose raw response context (#67) chore: addressing pr comments chore: merge conflict fixes chore: addressing pr comments
aorumbayev
added a commit
that referenced
this pull request
May 6, 2025
chore: adding more structure to api folder; automating generation of py|ts clients chore: refining stock template to leverage pytest over unittest and auto generate valid baseline tests chore: removing auto generated tests as they are too cumbersome to modify - Instead setting up a structure for custom mustache files implementing manually written tests given that each end point (total around 55) often requires complex state setup - For the time being the only test established is the test for sending raw transactions chore: refining base python tests; fixing typescript template chore: add basic txn params tests chore: refine python transaction tests chore: typescript client tweaks and initial tests docs: initial doc on api folder and oas generators chore: adding default pr and issue templates chore: refning docs chore: moving python ffi improvements to separate pr; adding basic ci for oas clients chore: expose raw response context (#67) chore: addressing pr comments chore: merge conflict fixes chore: addressing pr comments
aorumbayev
added a commit
that referenced
this pull request
May 6, 2025
chore: adding more structure to api folder; automating generation of py|ts clients chore: refining stock template to leverage pytest over unittest and auto generate valid baseline tests chore: removing auto generated tests as they are too cumbersome to modify - Instead setting up a structure for custom mustache files implementing manually written tests given that each end point (total around 55) often requires complex state setup - For the time being the only test established is the test for sending raw transactions chore: add basic txn params tests chore: typescript client tweaks and initial tests docs: initial doc on api folder and oas generators chore: adding default pr and issue templates chore: moving python ffi improvements to separate pr; adding basic ci for oas clients chore: expose raw response context (#67)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the template to expose the response context:
The reason for this change is that in utils-ts, I found that I need access to the raw binary returned from the http call. Currently, there are methods such as
rawTransactionWithHttpInfothat return theHttpInfo(wrapper of theResponseContext), there are some limitations:HttpInfois just a thin wrapper aroundResponseContext, I think we should just expose theResponseContextand the consumers have full control of how they want to use it.