Populate the ApplyData with inner transactions.

This also simplifies Log handling by using the same technique.

Lots more test of Pay in teal (with proper rewards handling)

Author: jannotti

data/transactions/logic/assembler.go

@@ -2041,7 +2041,7 @@ func parseIntcblock(program []byte, pc int) (intc []uint64, nextpc int, err erro
 	return
 }
 
-func checkIntConstBlock(cx *evalContext) error {
+func checkIntConstBlock(cx *EvalContext) error {
 	pos := cx.pc + 1
 	numInts, bytesUsed := binary.Uvarint(cx.program[pos:])
 	if bytesUsed <= 0 {
@@ -2109,7 +2109,7 @@ func parseBytecBlock(program []byte, pc int) (bytec [][]byte, nextpc int, err er
 	return
 }
 
-func checkByteConstBlock(cx *evalContext) error {
+func checkByteConstBlock(cx *EvalContext) error {
 	pos := cx.pc + 1
 	numItems, bytesUsed := binary.Uvarint(cx.program[pos:])
 	if bytesUsed <= 0 {
@@ -2267,7 +2267,7 @@ func disPushInt(dis *disassembleState, spec *OpSpec) (string, error) {
 	dis.nextpc = pos + bytesUsed
 	return fmt.Sprintf("%s %d", spec.Name, val), nil
 }
-func checkPushInt(cx *evalContext) error {
+func checkPushInt(cx *EvalContext) error {
 	opPushInt(cx)
 	return cx.err
 }
@@ -2287,7 +2287,7 @@ func disPushBytes(dis *disassembleState, spec *OpSpec) (string, error) {
 	dis.nextpc = int(end)
 	return fmt.Sprintf("%s 0x%s // %s", spec.Name, hex.EncodeToString(bytes), guessByteFormat(bytes)), nil
 }
-func checkPushBytes(cx *evalContext) error {
+func checkPushBytes(cx *EvalContext) error {
 	opPushBytes(cx)
 	return cx.err
 }

data/transactions/logic/assembler_test.go

@@ -2102,7 +2102,7 @@ func TestErrShortBytecblock(t *testing.T) {
 	_, _, err = parseIntcblock(ops.Program, 0)
 	require.Equal(t, err, errShortIntcblock)
 
-	var cx evalContext
+	var cx EvalContext
 	cx.program = ops.Program
 	err = checkIntConstBlock(&cx)
 	require.Equal(t, err, errShortIntcblock)

data/transactions/logic/debugger.go

@@ -86,7 +86,7 @@ func GetProgramID(program []byte) string {
 	return hex.EncodeToString(hash[:])
 }
 
-func makeDebugState(cx *evalContext) DebugState {
+func makeDebugState(cx *EvalContext) DebugState {
 	disasm, dsInfo, err := disassembleInstrumented(cx.program, nil)
 	if err != nil {
 		// Report disassembly error as program text
@@ -194,7 +194,7 @@ func valueDeltaToValueDelta(vd *basics.ValueDelta) basics.ValueDelta {
 	}
 }
 
-func (cx *evalContext) refreshDebugState() *DebugState {
+func (cx *EvalContext) refreshDebugState() *DebugState {
 	ds := &cx.debugState
 
 	// Update pc, line, error, stack, and scratch space